terraform-ls icon indicating copy to clipboard operation
terraform-ls copied to clipboard

Add Chocolatey packaging

Open paultyng opened this issue 4 years ago • 8 comments

paultyng avatar Apr 03 '20 14:04 paultyng

I created a separate issue for Homebrew as that can be done more easily, given that GoReleaser already supports that.

We could build Chocolatey support into GoReleaser and send it upstream, but it appears that creating custom packages for Chocolatey is quite different from Homebrew, so I reckon this will take more effort/time than just copying the existing logic for Homebrew.

The positive side is that upstream seems interested in having such functionality according to https://github.com/goreleaser/goreleaser/issues/131

radeksimko avatar Apr 18 '20 10:04 radeksimko

I'm not a Windows user myself, so I can't judge the popularity claims, but scoop seems to be another popular manager: https://www.onmsft.com/feature/scoop-or-chocolatey-which-windows-10-package-manager-should-you-use

and it is already supported by GoReleaser, so we could help Windows users by publishing scoop manifest in the meantime?

radeksimko avatar Apr 20 '20 08:04 radeksimko

@radeksimko good call, opened #55

I've never used Scoop personally, there is a relatively up to date TF package though, so seems like some users do.

paultyng avatar Apr 20 '20 13:04 paultyng

I think we can close this for now, see how things go with the new Windows packaging system.

paultyng avatar May 21 '20 01:05 paultyng

I think there's still reason to support Chocolatey, because they have an active existing user base + business behind it and likely won't go anywhere at least for years to come.

I think WinGet is going in the right direction and likely will build even larger user base over time (esp. if Microsoft starts bundling it with Windows by default), but it doesn't really have a good support for 3rd party sources yet, so we can't really do much there yet anyway.

IMO The point of distribution through a packaging systems is to get closer to our users and the way I see it is that most users are (and for foreseeable future will be) using Chocolatey.

That said I would like to support WinGet too, once they figure out the 3rd party sources thing.

radeksimko avatar May 21 '20 06:05 radeksimko

i have added choco as catchup for https://github.com/terraform-providers/terraform-provider-azurerm#on-windows . i think choco is good tactical decision to speed up azure people to be involved and contribute

dzmitry-lahoda avatar Aug 24 '20 09:08 dzmitry-lahoda

@radeksimko hey there, goreleaser seem to have lost interest in supporting choco, however they do support scoop which is in my opinion an even better choice for terraform-ls in that it doesn't need administrator access and installs all packages in the same directory, therefore not polluting the Path like with normal Windows installers.

Here is the documentation for it: https://goreleaser.com/customization/scoop/

adamency avatar May 17 '22 11:05 adamency

i switched to use scoop for all cli installs. it behaves more resonable, it is oss, unlike choco, and more hackable and has not legacy cpp code or nuget wrappers, and more diatributed via git repos. and design is more like embrace windows stuff, not try to make own ecosystem.

dzmitry-lahoda avatar May 17 '22 13:05 dzmitry-lahoda