terraform-cdk
terraform-cdk copied to clipboard
fix(cli): hcl render fails in false(bool), 0(int), ""(str) value
…tring
Related issue
Fixes #3621
Description
In plain English, describe your approach to addressing the issue linked above. For example, if you made a particular design decision, let us know why you chose this path instead of another solution.
Checklist
- [x] I have updated the PR title to match CDKTF's style guide
- [ ] I have run the linter on my code locally
- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation if applicable
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works if applicable
- [ ] New and existing unit tests pass locally with my changes
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.
@hashicorp/cdktf requesting to review this PR and suggested code
Hey, thanks for the help! Could you add a test case or two so we don't reintroduce the problem in the future?
Hi @DanielMSchmidt I have little understanding of terraform-cdk codebase, surrounding toolchain and also access to it It would be best if someone who has worked on this project to add test cases and do other checks I am fine with others using this code as reference and extend with changes and test cases to fix this issue as whole
Hi there! 👋 We haven't heard from you in 60 days and would like to know if you're still working on this or need help. If we don't hear from you before then, I'll auto-close this PR in 30 days.
I think this should be fixed by #3683 now 👍
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.