terraform-cdk icon indicating copy to clipboard operation
terraform-cdk copied to clipboard

Python package requires version>=3.7, not >=3.6

Open rirze opened this issue 3 years ago • 5 comments

Wanted to report that the python package cdktf_cdktf_provider_aws requires a minimum Python version of 3.7 due to an error:

SyntaxError: more than 255 arguments

(I don't have the original message anymore, but it should be easily replicated)

Upgrading to 3.7 negates this error since this python release removes the limit of 256 function arguments. I figured I should report this since PyPi and the package itself reports that Python >=3.6 should be sufficient when it is no longer the case.

rirze avatar Dec 20 '21 21:12 rirze

Thank you for the note @rirze! I just traced this back to JSII where the Python >= 3.6 requirement originates. So we might want to post a PR to JSII which either detects whether more than 255 arguments are used and sets the version to 3.7 or which allows us to set this from the outside somehow.

ansgarm avatar Jan 11 '22 14:01 ansgarm

I'll leave to others to decide whether it's really that critical to support 3.6 ;)

rirze avatar Jan 11 '22 15:01 rirze

Python 3.6 is end of life, so could probably just request to update to 3.7 everywhere.

jsteinich avatar Mar 09 '22 03:03 jsteinich

I think we can just increase the requirement to Python 3.7 on our side

DanielMSchmidt avatar Aug 12 '22 10:08 DanielMSchmidt

Jup, seems that JSII requires 3.7 now

ansgarm avatar Aug 12 '22 10:08 ansgarm

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Jul 06 '23 01:07 github-actions[bot]