terraform-aws-terraform-enterprise
terraform-aws-terraform-enterprise copied to clipboard
hashicorp
Update security baseline components and add encrypted/custom AMI support
Background
The current release of the module neither passes checkov security scans, nor does it pass Disney security baseline requirements. This merge request fixes both of those at the same time.
Additionally it also adds the ability to specify a custom AMI (search) as well as encrypted AMIs if an AMI KMS key is specified.
How Has This Been Tested
The testing was done by spinning up a TFE environment with the previous release of the module from the main branch and applying. Then the diff set here for the merge was applied to the environment to make sure no resources were munged or destroyed. Finally the existing EC2 instances for the active-active pair were terminated and new spun up in their place and they automatically stood up a working cluster.
Test Configuration
- Terraform Version: 0.15.1
- Any additional relevant variables: No
This PR makes me feel
Secure!
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Justice London seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.
/test all destroy=false
:x: Terraform Public Active/Active Test Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Validate
-
:x: Terraform Apply
-
:x: Run k6 Smoke Test
:white_check_mark: Terraform Private Active/Active Test Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Validate
-
:white_check_mark: Terraform Apply
-
:white_check_mark: Run k6 Smoke Test
:x: Terraform Private TCP Active/Active Test Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Validate
-
:white_check_mark: Terraform Apply
-
:x: Run k6 Smoke Test
/destroy private-active-active
:white_check_mark: Terraform Private Active/Active Destruction Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Destroy
/test private-tcp-active-active destroy=false
:white_check_mark: Terraform Private TCP Active/Active Test Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Validate
-
:white_check_mark: Terraform Apply
-
:white_check_mark: Run k6 Smoke Test
/destroy private-tcp-active-active
:white_check_mark: Terraform Private TCP Active/Active Destruction Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Destroy
/test all
:white_check_mark: Terraform Public Active/Active Test Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Validate
-
:white_check_mark: Terraform Apply
-
:white_check_mark: Run k6 Smoke Test
-
:white_check_mark: Terraform Destroy
:white_check_mark: Terraform Private TCP Active/Active Test Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Validate
-
:white_check_mark: Terraform Apply
-
:white_check_mark: Run k6 Smoke Test
-
:white_check_mark: Terraform Destroy
:x: Terraform Private Active/Active Test Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Validate
-
:white_check_mark: Terraform Apply
-
:x: Run k6 Smoke Test
-
:white_check_mark: Terraform Destroy
/test private-active-active destroy=false
:white_check_mark: Terraform Private Active/Active Test Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Validate
-
:white_check_mark: Terraform Apply
-
:white_check_mark: Run k6 Smoke Test
/destroy private-active-active
:white_check_mark: Terraform Private Active/Active Destruction Report
:link: Action Summary Page
-
:white_check_mark: Terraform Init
-
:white_check_mark: Terraform Destroy
Sounds good. Thanks for reviewing. I just have to get it through our legal/OSS process which should happen in a couple days.
@justicel Thank you for your contribution! As there has been no activity for a while on this PR, I shall close it. If you find your original concern and motivation to still be relevant, please consider creating an issue on which we can discuss the next steps.
