packer-plugin-vmware icon indicating copy to clipboard operation
packer-plugin-vmware copied to clipboard

refactor: consolidate workstation driver

Open tenthirtyam opened this issue 7 months ago • 0 comments

Description

  • Consolidates Workstation9Driver and Workstation10Driver to WorkstationrDriver within driver_workstation.go.
  • Addresses the deprecation of syscall.StringToUTF16Ptr with windows.UTF16PtrFromString in readRegString.

Testing

  • [x] Basic
  • [ ] End-to-End
packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 
➜ go fmt ./...

packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 
➜ make generate
2024/07/18 22:39:16 Copying "docs" to ".docs/"
2024/07/18 22:39:16 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 took 3.2s 
➜ make build  

packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 took 3.6s 
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.705s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.995s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    2.467s

packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 took 10.5s 
➜ make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_arm64

tenthirtyam avatar Jul 19 '24 02:07 tenthirtyam