packer-plugin-vmware
packer-plugin-vmware copied to clipboard
refactor: consolidate fusion driver
Description
Consolidates Fusion5Driver and Fusion6Driver to FusionDriver within driver_fusion.go.
Note: The minimum version should be set to VMware Fusion 13 per the Broadcom Product Lifecycle. However, we could hold this change, leave it as 6, and update all minimum versions simultaneously.
Testing
- [x] Basic
- [ ] End-to-End
acker-plugin-vmware on refactor/consolidate-fusion-driver [$] via 🐹 v1.22.5
➜ go fmt ./...
packer-plugin-vmware via 🐹 v1.22.5 …
➜ make generate
2024/07/18 22:42:30 Copying "docs" to ".docs/"
2024/07/18 22:42:30 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...
packer-plugin-vmware on refactor/consolidate-fusion-driver [$] via 🐹 v1.22.5 took 2.1s
➜ make build
packer-plugin-vmware on refactor/consolidate-fusion-driver [$] via 🐹 v1.22.5 took 3.6s
➜ make test
? github.com/hashicorp/packer-plugin-vmware [no test files]
? github.com/hashicorp/packer-plugin-vmware/version [no test files]
ok github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.698s
ok github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso 1.988s
ok github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx 2.462s
packer-plugin-vmware on refactor/consolidate-fusion-driver [$] via 🐹 v1.22.5 took 17.7s
➜ make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_arm64
Ready for initial review; e2e validations are still in flight with the latest updates.
Compare: e589d5e to 1de78ff
@lbajolet-hashicorp - this one is good to go now!
LGTM, thanks for the reroll @tenthirtyam!
Merging as soon as tests go green