packer-plugin-azure icon indicating copy to clipboard operation
packer-plugin-azure copied to clipboard

Updated code that validates managed_image_os_disk_snapshot_name and managed_image_data_disk_snapshot_prefix

Open VladimirKhvostov opened this issue 6 months ago • 3 comments

Description

MyImage2025.01.01-snapshot is a perfectly valid snapshot name, but original code does not accept it. Original code does not allow to use dots in the snapshot name.

Rollback Plan

Changes to Security Controls

No

VladimirKhvostov avatar Jul 15 '25 23:07 VladimirKhvostov

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Vladimir Khvostov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla-app[bot] avatar Jul 15 '25 23:07 hashicorp-cla-app[bot]

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Vladimir Khvostov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla-app[bot] avatar Jul 15 '25 23:07 hashicorp-cla-app[bot]

Hey @VladimirKhvostov this change seems good to me, thank you for the unit test changes as well.

Can you please sign the CLA mentioned in the previous comment? Once that's done I will validate it quickly and then we should be good to merge this

JenGoldstrich avatar Aug 01 '25 22:08 JenGoldstrich

@VladimirKhvostov Could you please sign the CLA so we can proceed with the PR?

tanmay-hc avatar Dec 15 '25 06:12 tanmay-hc