EBS volumes are left behind when using ebssurrogate with `use_create_image = true`

[lorengordon]

Overview of the Issue

EBS volumes are not cleaned up when using ebssurrogate with use_create_image = true. From the logs below, both vol-06a5bb097b689da36 and vol-003b56d111f16eb56 remain behind, in an unattached "Available" state.

Reproduction Steps

Create an image using ebssurrogate and set use_create_image = true.

Plugin and Packer version

❯ packer version
Packer v1.11.2

❯ packer plugins installed
/home/x/.config/packer/plugins/github.com/hashicorp/amazon/packer-plugin-amazon_v1.3.4_x5.0_linux_amd64
/home/x/.config/packer/plugins/github.com/hashicorp/azure/packer-plugin-azure_v2.1.7_x5.0_linux_amd64
/home/x/.config/packer/plugins/github.com/hashicorp/openstack/packer-plugin-openstack_v1.1.2_x5.0_linux_amd64
/home/x/.config/packer/plugins/github.com/hashicorp/vagrant/packer-plugin-vagrant_v1.1.4_x5.0_linux_amd64
/home/x/.config/packer/plugins/github.com/hashicorp/virtualbox/packer-plugin-virtualbox_v1.1.1_x5.0_linux_amd64

Simplified Packer Buildfile

I don't have a simple buildfile at the moment, hoping there's a test config already that can be executed to verify reproduction.

Operating system and Environment details

Should be irrelevant...

Log Fragments and crash.log files

==> amazon-ebssurrogate.minimal-ol-8-hvm: Detaching Root EBS Device Name: /dev/sda1, Volume ID: vol-06a5bb097b689da36
==> amazon-ebssurrogate.minimal-ol-8-hvm: Detaching Root EBS Device Name: /dev/xvdf, Volume ID: vol-003b56d111f16eb56
==> amazon-ebssurrogate.minimal-ol-8-hvm: Attaching Root EBS Device Name /dev/sda1, Volume ID: vol-003b56d111f16eb56
==> amazon-ebssurrogate.minimal-ol-8-hvm: Creating AMI spel-ci-minimal-ol-8-hvm-2024.12.dev1735591494.x86_64-gp3 from instance i-0f453ff06de2f64fe
    amazon-ebssurrogate.minimal-ol-8-hvm: AMI: ami-0e486a554fa252f78
==> amazon-ebssurrogate.minimal-ol-8-hvm: Waiting for AMI to become ready...
==> amazon-ebssurrogate.minimal-ol-8-hvm: Enabling deprecation on AMI (ami-0e486a554fa252f78) in region "us-gov-west-1" ...
==> amazon-ebssurrogate.minimal-ol-8-hvm: Skipping Enable AMI deregistration protection...
==> amazon-ebssurrogate.minimal-ol-8-hvm: Modifying attributes on AMI (ami-0e486a554fa252f78)...
    amazon-ebssurrogate.minimal-ol-8-hvm: Modifying: description
==> amazon-ebssurrogate.minimal-ol-8-hvm: Modifying attributes on snapshot (snap-04be024efdb802c2c)...
==> amazon-ebssurrogate.minimal-ol-8-hvm: Adding tags to AMI (ami-0e486a554fa252f78)...
==> amazon-ebssurrogate.minimal-ol-8-hvm: Tagging snapshot: snap-04be024efdb802c2c
==> amazon-ebssurrogate.minimal-ol-8-hvm: Terminating the source AWS instance...
==> amazon-ebssurrogate.minimal-ol-8-hvm: Cleaning up any extra volumes...
==> amazon-ebssurrogate.minimal-ol-8-hvm: Deleting temporary security group...
==> amazon-ebssurrogate.minimal-ol-8-hvm: Deleting temporary keypair...
Build 'amazon-ebssurrogate.minimal-ol-8-hvm' finished after 33 minutes 14 seconds.