api: exit EventStream.Stream on first error

Open schmichael opened this issue 3 months ago • 0 comments

Errors from Decode are non-recoverable and should cause Stream to return. Otherwise Stream will loop forever on EOF from Decode.

Fixes #27133

Repro: https://gist.github.com/schmichael/247a39bf36406c08c8a95fc8c85bd56a

[ ] Changelog Entry If this PR changes user-facing behavior, please generate and add a changelog entry using the make cl command.
[ ] Testing Please add tests to cover any new functionality or to demonstrate bug fixes and ensure regressions will be caught.
[ ] Documentation If the change impacts user-facing functionality such as the CLI, API, UI, and job configuration, please update the Nomad product documentation, which is stored in the web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines. Please also consider whether the change requires notes within the upgrade guide. If you would like help with the docs, tag the nomad-docs team in this PR.

[ ] Backport Labels Please add the correct backport labels as described by the internal backporting document.
[ ] Commit Type Ensure the correct merge method is selected which should be "squash and merge" in the majority of situations. The main exceptions are long-lived feature branches or merges where history should be preserved.
[ ] Enterprise PRs If this is an enterprise only PR, please add any required changelog entry within the public repository.

[ ] If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Nov 22 '25 01:11 schmichael