nomad icon indicating copy to clipboard operation
nomad copied to clipboard

ui: add choose template button

Open ChaiWithJai opened this issue 2 years ago • 3 comments

Resolves #15546.

This PR creates a link (button) in the jobs.run view to allow a user to select a template to populate the job definition.

Current Design: image

Figma Mock (has an a11y contrast violation): image

Side Effects and notes:

  • This PR updates the file directory to have a jobs/run and jobs/run/templates subdirectories.
  • This PR populates dummy markup for acceptance tests.
  • This PR doesn't make full use of styling in the Figma mocks because of a11y violations and waiting for #15582 to be merged in for appropriate component consumption.
  • The original Figma mock (screenshot above) includes an a11y color contrast violation. To circumvent this issue we should default to using primary and secondary buttons given to us from HDS. This can be addressed in the subsequent PR.

ChaiWithJai avatar Dec 20 '22 18:12 ChaiWithJai

Ember Asset Size action

As of 889b098

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +11.1 kB +1.95 kB
nomad-ui.css +488 B +118 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

github-actions[bot] avatar Dec 20 '22 18:12 github-actions[bot]

Ember Test Audit comparison

epic/job-templates dace24f499f559d9d749672d1e9ae8cee8209274 change
passes 1453 1454 +1
failures 1 0 -1
flaky 0 0 0
duration 000ms 10m 42s 832ms +10m 42s 832ms

github-actions[bot] avatar Dec 20 '22 22:12 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nomad-storybook-and-ui 🔄 Building (Inspect) Dec 21, 2022 at 9:27PM (UTC)

vercel[bot] avatar Dec 21 '22 21:12 vercel[bot]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 10 '23 02:05 github-actions[bot]