nomad
nomad copied to clipboard
Fix rejoin_after_leave behavior
This will effectively change the default behavior of Serf to not rejoin after leave, which (I believe...) is actually the documented behavior. But this could be perceived as a breaking change by some cluster operators who may be accustomed to server nodes ignoring leave events.
Alternative approaches which would not change the default behavior would be
- use a bool pointer in this config field in order to be able to discern
nil(not configured) from intentionallyfalse, and default totrueas exists today - introduce a new config field
disable_rejoin_after_leavewhich would default tofalseand therefore continue to produce the current behavior
In any case, docs probably need to be updated here and if necessary, a behavior change be communicated out.
@anth0d is attempting to deploy a commit to the HashiCorp Team on Vercel.
A member of the Team first needs to authorize it.
@anth0d I think we've got the CI issue fixed. Would you mind rebasing on main to verify that?
Thanks @tgross, could you authorize the new preview app deployment?
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.