nomad icon indicating copy to clipboard operation
nomad copied to clipboard

Fix rejoin_after_leave behavior

Open anth0d opened this issue 2 years ago • 2 comments

This will effectively change the default behavior of Serf to not rejoin after leave, which (I believe...) is actually the documented behavior. But this could be perceived as a breaking change by some cluster operators who may be accustomed to server nodes ignoring leave events.

Alternative approaches which would not change the default behavior would be

  • use a bool pointer in this config field in order to be able to discern nil (not configured) from intentionally false, and default to true as exists today
  • introduce a new config field disable_rejoin_after_leave which would default to false and therefore continue to produce the current behavior

In any case, docs probably need to be updated here and if necessary, a behavior change be communicated out.

anth0d avatar Dec 14 '22 22:12 anth0d

@anth0d is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 14 '22 22:12 vercel[bot]

@anth0d I think we've got the CI issue fixed. Would you mind rebasing on main to verify that?

tgross avatar Jan 04 '23 21:01 tgross

Thanks @tgross, could you authorize the new preview app deployment?

anth0d avatar Jan 11 '23 17:01 anth0d

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 12 '23 02:05 github-actions[bot]