nomad icon indicating copy to clipboard operation
nomad copied to clipboard

cli: Add a nomad operator client state command

Open dttung2905 opened this issue 2 years ago • 6 comments
trafficstars

Resolve issue #15447

Please let me know if you want to change to nomad operator client state and update the documentation too!

dttung2905 avatar Dec 04 '22 10:12 dttung2905

@dttung2905 is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 07 '22 16:12 vercel[bot]

Hi @dttung2905! Thanks for opening this PR!

I've left a few comments and gave a suggestion for how to workaround the import issue for the structs package. Also, yes let's get a page added to the docs. And can you run make cl to add a changelog entry? Thanks!

Thanks a lot for the swift reply. I have added the changelog entry.

Could I confirm that this is the path to add the new doc page ? website/content/docs/commands/operator Do we have any cli command to skaffold a template doc? If not I will copy from an existing one and edit accordingly :smile:

dttung2905 avatar Dec 07 '22 16:12 dttung2905

Could I confirm that this is the path to add the new doc page ? website/content/docs/commands/operator

Yes! You'll also need to add a bit of JSON in docs-nav-data.json right before the nomad operator debug command.

Do we have any cli command to skaffold a template doc? If not I will copy from an existing one and edit accordingly

Unfortunately no, so yeah just go ahead and copy an existing one.

tgross avatar Dec 12 '22 16:12 tgross

Hi @tgross, Thanks for the quick response for yesterday PR. If you have some time, could you help to review this MR as well ?

dttung2905 avatar Jan 05 '23 12:01 dttung2905

If you have some time, could you help to review this MR as well ?

Yup, I haven't forgotten this! :grin: I've got a pending review open already in fact but I'm getting pulled away to deal with something urgent. Will circle back as soon as I can. Thanks for your patience!

tgross avatar Jan 05 '23 14:01 tgross

Yup, I haven't forgotten this! grin I've got a pending review open already in fact but I'm getting pulled away to deal with something urgent. Will circle back as soon as I can. Thanks for your patience!

Thanks Tim for the super quick reply. I totally understood and no worries about that! Happy New Year btw !

dttung2905 avatar Jan 05 '23 14:01 dttung2905

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nomad-storybook-and-ui 🔄 Building (Inspect) Jan 6, 2023 at 5:02PM (UTC)

vercel[bot] avatar Jan 06 '23 17:01 vercel[bot]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 12 '23 02:05 github-actions[bot]