nomad icon indicating copy to clipboard operation
nomad copied to clipboard

naive solution

Open ChaiWithJai opened this issue 3 years ago • 1 comments

This is a naive solution to resolve #14654.

The issue manifests itself where you navigate to the allocations.allocation.index view and you see Ports. Then navigate up using breadcrumbs back to TaskGroup and click on the same allocation, you'll notice that Ports are now gone.

Here's a Replay that captures this behavior.

This PR doesn't resolve the root cause of this issue: some line of code somewhere is manipulating our store.

However, this PR ensures that every time we enter this route via TaskGroup that we will guarantee a API call to get the latest Allocation information. That's because the LinkTo component API skips calling the model hook if we pass a full model as an argument, and we definitely don't want that because we have real-time concerns. Editing the invocation of the LinkTo component to accept the id of our allocation instead of the full model will force us to call the model hook and make the appropriate API call which will include our Ports onto this view.

ChaiWithJai avatar Oct 04 '22 20:10 ChaiWithJai

Ember Asset Size action

As of 926b78e

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +5 B +2 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

github-actions[bot] avatar Oct 04 '22 20:10 github-actions[bot]

Ops, just noticed that it's missing a changelog entry and backport labels 👍

lgfa29 avatar Oct 20 '22 00:10 lgfa29

Ember Test Audit comparison

investigation-missing-fields 926b78e15854058f1520193db86f4466c4bcf3b8 change
passes 1421 1421 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

github-actions[bot] avatar Oct 20 '22 20:10 github-actions[bot]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Feb 19 '23 02:02 github-actions[bot]