nomad
nomad copied to clipboard
drivers/docker: add context timeouts to docker client calls
@danishprakash did you intend for this PR to still be marked as a Draft? If not, do you mind rebasing with main and marking it Ready for Reveiw?
@shoenig yeah, I marked it as a draft since I wanted some inputs from the team and I hadn't gone through the whole codebase with this change. But I think you can go ahead and review it if you can and I can then address the comments.
Sorry for the super slow responses @danishprakash :grimacing:
One key change I think we should make is making the timeout value configurable in the docker plugin configuration.
Similar to how we already have an option for pull_activity_timeout, let's add something like endpoint_timeout which is general for all other docker endpoint interactions.
So we'll want add that, then apply it to all the places we can, and update the docs.