nomad icon indicating copy to clipboard operation
nomad copied to clipboard

drivers/docker: add context timeouts to docker client calls

Open danishprakash opened this issue 3 years ago • 3 comments

Closes #9503

Signed-off-by: danishprakash [email protected]

danishprakash avatar Jun 19 '22 14:06 danishprakash

@danishprakash did you intend for this PR to still be marked as a Draft? If not, do you mind rebasing with main and marking it Ready for Reveiw?

shoenig avatar Sep 22 '22 15:09 shoenig

@shoenig yeah, I marked it as a draft since I wanted some inputs from the team and I hadn't gone through the whole codebase with this change. But I think you can go ahead and review it if you can and I can then address the comments.

danishprakash avatar Oct 19 '22 04:10 danishprakash

Sorry for the super slow responses @danishprakash :grimacing:

One key change I think we should make is making the timeout value configurable in the docker plugin configuration.

Similar to how we already have an option for pull_activity_timeout, let's add something like endpoint_timeout which is general for all other docker endpoint interactions.

So we'll want add that, then apply it to all the places we can, and update the docs.

shoenig avatar Dec 22 '22 16:12 shoenig