nomad-driver-podman icon indicating copy to clipboard operation
nomad-driver-podman copied to clipboard

Added support for using existing network stack

Open joshiparth1000 opened this issue 3 years ago • 4 comments

Support for using existing network stack

joshiparth1000 avatar May 27 '21 21:05 joshiparth1000

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • [x] joshiparth1000
  • [ ] Parth Joshi

Parth Joshi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar May 27 '21 21:05 hashicorp-cla

@joshiparth1000 thank you for your contribution! I will take a closer look within a few days. Maybe you can check PR #116 in the meantime to see if there is some feature overlap with your work? Both branches enhance the drivers network interoperability.

towe75 avatar May 28 '21 20:05 towe75

@joshiparth1000 : What about integrating your feature with the existing network_mode driver configuration option. It would build upon the ideas from #116, adding a network_mode=pod:somepod and network_mode=cni:first,second

towe75 avatar Jun 01 '21 18:06 towe75

Yes, that will work as well. I am up for it.

joshiparth1000 avatar Jun 01 '21 20:06 joshiparth1000

As mentioned in #173 Podman is dropping CNI support in v5.

shoenig avatar Jun 12 '23 15:06 shoenig