levant icon indicating copy to clipboard operation
levant copied to clipboard

feat: Add support for using jobspec2 parser

Open alexdulin opened this issue 3 years ago • 9 comments

This adds in support for using the HCL2 jobspec2 parser with a new -hcl2 flag. This allows for using new features like upstreams.datacenter and terminating gateways. It should also allow for new features in the future to be used that are only being added to the new jobspec2 parser.

Since using the jobspec2 parser and HCL2 can break existing job files, I decided to implement this as opt-in rather than opt-out, having the default be to use the original jobspec parser.

Signed-off-by: Alex Dulin [email protected]

alexdulin avatar Mar 08 '21 14:03 alexdulin

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 08 '21 14:03 hashicorp-cla

@jrasell Any chance this could get a review? Its been open for a while now and adds quite a bit of functionality and fixes to other issues people have been opening.

Apologies in advance for @'ing you directly.

alexdulin avatar Jun 20 '21 22:06 alexdulin

@jrasell addressed all your comments in initial review. Thanks!

alexdulin avatar Jul 27 '21 12:07 alexdulin

@tgross @jrasell I apologize for bugging you in advance, but is there any chance of this getting merged? All comments were addressed almost half a year ago and it would be great to get off of the fork of Levant we currently use, which is based on this branch.

If this MR is not going anywhere, it would be greatly appreciated to know that so we can start implementing more long term solutions on our own.

alexdulin avatar Nov 14 '21 02:11 alexdulin

@alexdulin i'll put this on my list for early this week!

jrasell avatar Nov 15 '21 07:11 jrasell

Hello team it is 2022 and seems like this important PR is still in the review stage.

bbarman4u avatar Feb 16 '22 11:02 bbarman4u

@alexdulin and @bbarman4u yep my bad, this slipped through the gaps. I'll try and find some time to give this another look and test.

jrasell avatar Feb 16 '22 11:02 jrasell

I would be really interested in seeing this PR merged in as well 👍

droustchev avatar Apr 22 '22 20:04 droustchev

Any chance this could get merged in?

mharp-zenimax avatar Aug 26 '22 15:08 mharp-zenimax