levant
levant copied to clipboard
hashicorp
added in a "monitor" subcommand to monitor jobs to completion
Hi @jrasell,
I've finally managed to circle back around and get this sorted out. I've refactored the monitor function to be its own subcommand as we had discussed. I named it "monitor" (instead of "batch-monitor" or similar) because it can technically be used to monitor services or system jobs as well as batch jobs. I've also updating things to match how you are doing the CLI components.
I opened a new pull request for this since its so radically different from what I had before.
Meant to resolve #77
Thanks!
I think the check failures are an error in the checks. It seems to say that the MonitorCommand struct is not being used, but it is used in the commands.go file. Am I understanding that incorrectly?
@dansteen the check is pointing the the args field not being used within the MonitorCommand struct.
@jrasell ok. fixed up the args issue, and also fixed up things to use new logging stuff.
thanks @dansteen; I am going to push out a release and then get this in to 0.2.0 if that is OK for you?
@jrasell any chance of getting this in for the 0.2.0 that is being worked on now?
yes sorry my bad; I have been a bit slack the past few weeks. are you able to resolve the conflict and I will get it in today
pretty sure it's just our conversation above from the 26th. I don't think there are any actual conflicts.
the conflict as in the merge conflict; if not I will fix it up when I have a moment later/tomorrow morning
This seems pretty great and our team could definitely use this -- we're shipping database migrations prior to deploying new code and would love levant to verify that the tasks completed correctly or exit non-zero
If given commit bit, I'd be happy to fix the merge conflicts (and merge once @jrasell gives second approval) :)
This is very useful feature, @jrasell is there a way to move it forward? Thanks
@eugengarkusha and @jrasell I signed the CLA just in case that was the only thing holding it back.