golang-lru icon indicating copy to clipboard operation
golang-lru copied to clipboard

add bettermap instead of go map

Open xuetusc opened this issue 3 years ago • 2 comments

add bettermap instead of go map delete go map key will only label it, not really delete that causes memory leak.

xuetusc avatar Sep 28 '22 07:09 xuetusc

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


renbiao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Sep 28 '22 07:09 hashicorp-cla

This code isn't thread safe. What's the memory leak exactly?

Is the benefit you see merely from swapping out the map instead of removing items?

jefferai avatar Oct 21 '22 13:10 jefferai