go-tfe icon indicating copy to clipboard operation
go-tfe copied to clipboard

go-slug update breaks TF uploads with symlinks

Open jakeyheath opened this issue 2 years ago • 2 comments

go-tfe utilizes go-slug in their update functionality. This PR of go-slug disallows symlinks be default and adds an option for the user to specify paths that symlinks should be allowed. However, go-tfe doesn't expose this new option to the user when calling Update.

We are currently utilizing go-tfe to package up a Terraform directory that contains symlinks, but getting the following error:

failed to get relative path for file "<PATH_TO_SYMLINK>": Rel: can't make <PATH_TO_SYMLINK> relative to ../../modules

jakeyheath avatar Aug 18 '22 18:08 jakeyheath

👋 @jakeyheath

Thank you for submitting this issue! We'll take a look and get back to you about this. 

Uk1288 avatar Aug 18 '22 19:08 Uk1288

@jakeyheath Thanks for flagging! Would you mind providing any config (and steps) that may be helpful in recreating the issue? Feel free to X-out any sensitive info.

laurenolivia avatar Aug 24 '22 21:08 laurenolivia

Hi @jakeyheath, writing to inform you that I will be closing this ticket. If this error happens again, please open another ticket and provide any necessary config so our team is able to reproduce the issue. Thank you! ⭐

laurenolivia avatar Sep 27 '22 17:09 laurenolivia