go-tfe icon indicating copy to clipboard operation
go-tfe copied to clipboard

Validate the module version as version instead of ID

Open svanharmelen opened this issue 2 years ago • 5 comments

Without these changes a module version with prerelease or metadata will fail, while these are actually valid SemVer versions that are allowed by the module registry.

The PR includes tests that fail without the additional code changes, so everything that is needed should be in here...

svanharmelen avatar May 21 '22 09:05 svanharmelen

Rebased to fix the merge conflicts...

svanharmelen avatar Jun 07 '22 07:06 svanharmelen

Hi @svanharmelen - could you please update your fork with main? We'd like to get this PR merged. Thank you! 🥳

annawinkler avatar Aug 12 '22 16:08 annawinkler

@annawinkler done... Noticed the integration tests failed, but its because of a missing token so don't think it's related to the changed in the PR 🤷🏻‍♂️

svanharmelen avatar Aug 12 '22 17:08 svanharmelen

@svanharmelen Thank you! Yes, we'll take a look at that.

annawinkler avatar Aug 17 '22 14:08 annawinkler

@annawinkler It is approved now, can this also be merged and released? Would be nice if we can remove our forked repo out of ecosystem 😉

fatbasstard avatar Sep 15 '22 10:09 fatbasstard

Opened a new PR #571 so I can get tests to run. Will close this PR after the new one is merged.

annawinkler avatar Oct 31 '22 14:10 annawinkler

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

github-actions[bot] avatar Oct 31 '22 15:10 github-actions[bot]