go-tfe icon indicating copy to clipboard operation
go-tfe copied to clipboard

resources list

Open estenssoros opened this issue 3 years ago • 4 comments

Description

This is my first time submitting a PR to a mature product like go-tfe. Any feedback would be much appreciated. I created this PR because I would like to be able to list the resources available in a workspace.

Testing plan

  1. Describe how to replicate
  2. the conditions
  3. under which your code performs its purpose,
  4. including example code to run where necessary.

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from tests

I could use some help figuring out how to test this. Do I need to stand up a terraform enterprise deployment? Is there a docker image available?

I also tied to emulate other tests that I have seen in this repo. Let me know if I should add other or need to change what I have.

$ go test

...

estenssoros avatar Oct 07 '21 15:10 estenssoros

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • [x] estenssoros
  • [ ] Sebastian Estenssoro

Sebastian Estenssoro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Oct 07 '21 15:10 hashicorp-cla

@estenssoros Hi Sebastian! Thank you for your contribution. Just a reminder that you'll need to sign the HashiCorp CLA agreement (https://github.com/hashicorp/go-tfe/pull/265#issuecomment-937925154) before our pipeline can run additional tests.

uturunku1 avatar Oct 18 '21 18:10 uturunku1

Thanks @brandonc! Sorry I missed the notification for this (I need to figure out how to set that up). I will add this to my todo list

estenssoros avatar Nov 12 '21 15:11 estenssoros

@estenssoros I see that you've added a commit to address @brandonc's feedback. Thank you for doing that. It looks like there is a conflict now, though. Can you resolve that?

barrettclark avatar Jun 17 '22 20:06 barrettclark

Hi @estenssoros 👋 Thank you for your contribution! We'd like to get this PR merged, and to do so, we'll first need you to sign to Contributor License Agreement (you can click on the link in the workflow to do this). Next, there are a few small things to update in this PR:

  • Update ResourceListOptions per this comment
  • Add a changelog entry for this change
  • Update the coverage checkbox (see the Contributing docs for more info)

Thank you! ✨

annawinkler avatar Oct 31 '22 17:10 annawinkler

hey hey, i'm finally able to sign the contributing docs since I am not longer with my previous employer. I'm going to close and reopen this PR to avoid merge conflicts

estenssoros avatar Nov 28 '22 16:11 estenssoros