design-system
design-system copied to clipboard
[DO NOT MERGE] flaky test investigation
nothing to see here, yet.
Things that I've done as I've identified test errors (and tried to fix) and other changes/refactoring to try to reduce test flakiness:
- use
@embroider/macrosfor the link-to-external util - replaced the get in the intl service with a direct injection of the intl service (so that anything that uses our intl service is more stable and teardown safe due to delegation of ownership to the framework)
- added a
isDestroyed/isDestroyingguard/check to advanced table itself - add a little extra oomph for RAF in advanced table tests (the tests aren't getting the same help a consumer implementation would)
- added an ember-try scenario called
hds-emberso we can make sure we're testing the actual version (or near enough) that we're using (and updated the workflow for components); I have it turned off at the moment until the rest of the tests are passing. - figured out why we needed to skip an assertion test in the tabs test, and updated the comment to reflect
Things I tried to figure out but 🤷
- the time-related tests. I don't know why one week later is 8 days. Randomly 8 days, randomly 7 days. Probably some rounding error or there was a time change in the server where this is all called from, while I was running the tests? Ugh. What is time, even.
Here's how tests shake out when I run them locally:
The latest updates on your projects. Learn more about Vercel for GitHub.
| Project | Deployment | Preview | Updated (UTC) |
|---|---|---|---|
| hds-showcase | Preview | Nov 18, 2025 5:41pm | |
| hds-website | Preview | Nov 18, 2025 5:41pm |
Closed in favor of breaking it up into more targeted PRs.