design-system icon indicating copy to clipboard operation
design-system copied to clipboard
verified publisher icon hashicorp

chore(showcase): `eslint` & `prettier`

Open aklkv opened this issue 9 months ago • 3 comments

:pushpin: Summary

  • add latest eslint and prettier setup
  • bump pnpm

:hammer_and_wrench: Detailed description

:camera_flash: Screenshots

:link: External links

Jira ticket: HDS-XXX Figma file: [if it applies]

👀 Component checklist

  • [ ] Percy was checked for any visual regression
  • [ ] A changelog entry was added via Changesets if needed (see templates here)

:speech_balloon: Please consider using conventional comments when reviewing this PR.

aklkv avatar Apr 03 '25 07:04 aklkv

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 20, 2025 5:56am
hds-website ✅ Ready (Inspect) Visit Preview May 20, 2025 5:56am

vercel[bot] avatar Apr 03 '25 07:04 vercel[bot]

As mentioned in another PR/comment, I strongly think we need to find a way to isolate the changes to the CSS files and have another tool to do the linting for them. Some of the changes I see are too drastic/draconian, and are not what was collectively decided time ago by the HDS team about CSS linting rules.

/cc @alex-ju

didoo avatar Apr 14 '25 15:04 didoo

@aklkv FYI @alex-ju is OO until May 5 so unless it's urgent/blocker I would wait for him to come back (he has much more context about these changes and the previous PRs)

didoo avatar Apr 22 '25 12:04 didoo

@alex-ju is there anything I can help here to move it forward?

aklkv avatar May 13 '25 02:05 aklkv

I strongly think we need to find a way to isolate the changes to the CSS files and have another tool to do the linting for them. Some of the changes I see are too drastic/draconian, and are not what was collectively decided time ago by the HDS team about CSS linting rules.

The main concern with this PR seems to be around Sass linting. Now, I'm not sure what alternatives we have here. @didoo would it work for you if @aklkv disables prettier for Sass – keeping the code as is – and we plan to look for alternatives at a later point? or do you prefer having it resolved as part of this PR?

alex-ju avatar May 13 '25 08:05 alex-ju

@didoo would it work for you if @aklkv disables prettier for Sass

yes, that would be the pragmatic thing to do, for me

didoo avatar May 13 '25 10:05 didoo

@didoo @alex-ju I have removed all changes to *.scss and added it to prettierignore pattern. Let me know if you would like me to address anything else 🙏

aklkv avatar May 14 '25 08:05 aklkv

@didoo @alex-ju I have removed all changes to *.scss and added it to prettierignore pattern. Let me know if you would like me to address anything else 🙏

I'll let @alex-ju have a look (he has more context/knowledge)

didoo avatar May 14 '25 11:05 didoo

@alex-ju I had to rebase, can I have another ✅ please

aklkv avatar May 20 '25 06:05 aklkv