design-system icon indicating copy to clipboard operation
design-system copied to clipboard

`FlightIcon` => `Hds::Icon` Migration - `packages/components`

Open zamoore opened this issue 1 year ago • 2 comments

:pushpin: Summary

If merged, this PR updates instances of FlightIcon within components to use the Hds::Icon component.

:link: External links

Jira ticket: HDS-3709


:speech_balloon: Please consider using conventional comments when reviewing this PR.

zamoore avatar Aug 13 '24 22:08 zamoore

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Aug 23, 2024 3:58pm
hds-website ✅ Ready (Inspect) Visit Preview Aug 23, 2024 3:58pm

vercel[bot] avatar Aug 13 '24 22:08 vercel[bot]

A few spots you might want to remove references to ember-flight-icons packages:

https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/packages/components/package.json#L23

https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/packages/components/package.json#L42

https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/packages/components/rollup.config.mjs#L45

https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/packages/components/README.md#L40

once all other PRs are merged CI references needs to be cleaned up as well

aklkv avatar Aug 13 '24 23:08 aklkv