design-system icon indicating copy to clipboard operation
design-system copied to clipboard

Updates version of ember-a11y-refocus

Open MelSumner opened this issue 1 year ago • 2 comments

:pushpin: Summary

If merged, this PR updates the version of ember-a11y-refocus. It's a patch version that resolves issues TFC was having with the new excludeAllQueryParams flag.

Tested this with @deanmarano (who can confirm) and this resolves the issue he was seeing in Terraform.


:speech_balloon: Please consider using conventional comments when reviewing this PR.

MelSumner avatar Aug 13 '24 18:08 MelSumner

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Aug 21, 2024 1:34am
hds-website ✅ Ready (Inspect) Visit Preview Aug 21, 2024 1:34am

vercel[bot] avatar Aug 13 '24 18:08 vercel[bot]

You'll want to add a patch changeset for the change to the components package

Dhaulagiri avatar Aug 13 '24 19:08 Dhaulagiri

@Dhaulagiri any idea why adding a changeset would cause Percy to fail? 🤔

MelSumner avatar Aug 19 '24 18:08 MelSumner

Not 100% sure but likely something got merged to main that isn't in your branch. I suspect rebasing this branch on main would clear that up.

Dhaulagiri avatar Aug 19 '24 18:08 Dhaulagiri

Something in my git rebase didn't work correctly, so I'm just going to redo this PR.

MelSumner avatar Aug 21 '24 01:08 MelSumner