design-system icon indicating copy to clipboard operation
design-system copied to clipboard

`CopySnippet`: convert to TypeScript (HDS-2689)

Open KristinLBradley opened this issue 9 months ago • 1 comments

:pushpin: Summary

If merged, this PR converts the CopySnippet to TypeScript.

Note: Based off CopyButton branch: https://github.com/hashicorp/design-system/pull/2100 as they both share usage of hds-clipboard modifier

:link: External links


👀 Component checklist

  • ~~[ ] Percy was checked for any visual regression~~
  • [x] A changelog entry was added via Changesets if needed (see templates here)

:speech_balloon: Please consider using conventional comments when reviewing this PR.

KristinLBradley avatar May 16 '24 23:05 KristinLBradley

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 23, 2024 7:01pm
hds-website ✅ Ready (Inspect) Visit Preview May 23, 2024 7:01pm

vercel[bot] avatar May 16 '24 23:05 vercel[bot]

@didoo I've been trying to rebase this branch onto hds-2688-copy-button-ts-conversion but keep getting conflicts and when I try to fix the conflicts and continue rebasing the conflicts re-occur.

KristinLBradley avatar May 23 '24 18:05 KristinLBradley

@didoo I've been trying to rebase this branch onto hds-2688-copy-button-ts-conversion but keep getting conflicts and when I try to fix the conflicts and continue rebasing the conflicts re-occur.

For future reference: this was fixed yesterday with a rebase of the branch hds-2689-copy-snippet-ts-conversion on hds-2688-copy-button-ts-conversion (and in the process of fixing conflicts I've merged and/or cleaned up a few commits) and then messaged Kristin to let her know.

didoo avatar May 24 '24 16:05 didoo