Revert to davecgh/go-spew in go.mod to no longer use a psuedoversion.

[TomHellier]

Description

This doesn't actually result to any changes in the code, but this dependency is being imported by users of this library and conflicting with other installations of go-spew (which is a dependency of the common testing library stretchr/testify, although issues exist to remove go-spew, it is likely it won't happen.).

go-spew hasn't had any updates for a very long time, and is probably unmaintained , and this is breaking gopls dependency analysis:

Note: This error is on prometheus, because they are importing this library, and my code is also using testify, but using the latest 'real' release.

Command 'gopls.upgrade_dependency' failed: Error: err: exit status 1: stderr: go: -d flag is deprecated. -d=true is a no-op
go: github.com/prometheus/prometheus@upgrade (v0.304.1) requires github.com/davecgh/[email protected], not github.com/davecgh/go-spew@upgrade (v1.1.1)

The only difference between these two versions, is that v1.1.1 is a released version, and someone updated to a psuedo version which includes the following commit: https://github.com/davecgh/go-spew/commit/d8f796af33cc11cb798c1aaeb27a4ebc5099927d

The version was updated as part of this PR, and I think it was probably done accidentally.

You can see that kubernetes has recently reverted a similar change, which was possible because kustomize PR 5830 reverted kustomize PR 5615 (another accidental psuedo version bump). These ripple effects through golang dependencies are quite disruptive and have rippled up to me because prometheus imports hashicorp/consul, and I import prometheus for my metrics in golang.

This shouldn't really have any impact

Testing & Reproduction steps

Links

PR Checklist

• [x] updated test coverage
• [x] external facing docs updated
• [x] appropriate backport labels added
• [x] not a security concern

[github-actions[bot]]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

[TomHellier]

not stale, would like someone to respond please

[github-actions[bot]]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

[TomHellier]

Not stale