consul
consul copied to clipboard
Fix #20769 : Feature - Allow users to set global label in the UI.
Description
Fixes #20769
Testing & Reproduction steps
Create config file with -
"ui_config": { "enabled" :true, "label":{ "text": "Development", "background_color": "green", "text_color": "white" } }
Approach
Instead of creating a new internal/ui endpoint just for the sake of getting label configuration that would be called eventhough user never configured it, the label configuration is passed as resp headers in /v1/catalog/datacenters
endpoint which is the first endpoint called on ui load.
Links
PR Checklist
- [x] updated test coverage
- [ ] external facing docs updated
- [ ] appropriate backport labels added
- [ ] not a security concern
UI tests :
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.
Hi @david-yu / @jkirschner-hashicorp / @huikang , Reminding to kindly take this PR for review.
also as @akamensky requested need backport to 1.16
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.