consul icon indicating copy to clipboard operation
consul copied to clipboard

Support Envoy's MaxEjectionPercent and BaseEjectionTime config entries for passive health checks

Open analogue opened this issue 2 years ago • 2 comments

Description

WAN federated clusters are not able to failover all traffic from one datacenter to another via passive healthchecks when the control plane is down without being able to set MaxEjectionPercent to 100%. BaseEjectionTime just provides additional configurability on the backoff interval until the max ejection interval is hit.

Testing & Reproduction steps

  • Existing passive health check unit tests updated
  • Existing passive health check integration tests updated to verify configuration
  • Open to adding a functional integration test if it would be useful, however I'm planning to add support for these config values via K8s CRDs in the consul-k8s repo. e2e tests on K8s might be more useful.

PR Checklist

  • [x] updated test coverage
  • [x] external facing docs updated
  • [x] not a security concern

analogue avatar Jan 13 '23 21:01 analogue

@analogue I assume a consul-k8s crd update is also in order?

david-yu avatar Jan 13 '23 22:01 david-yu

@analogue I assume a consul-k8s crd update is also in order?

Yep, that is coming up next 😄.

analogue avatar Jan 13 '23 22:01 analogue

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar Mar 27 '23 01:03 github-actions[bot]

Added backport/1.15 since 1.15 is now out.

david-yu avatar Apr 26 '23 17:04 david-yu

Looks like this did not backport at all for 1.14 and 1.15.

david-yu avatar Apr 26 '23 23:04 david-yu

Thank you for this feature but can we also document it on https://developer.hashicorp.com/consul/docs/v1.14.x/connect/proxies/envoy#passive_health_check?

Thanks!

komapa avatar May 25 '23 03:05 komapa