consul icon indicating copy to clipboard operation
consul copied to clipboard

state: deregister service with sunken token

Open blaggacao opened this issue 4 years ago • 14 comments

fixes: #12145

blaggacao avatar Mar 15 '22 20:03 blaggacao

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 15 '22 20:03 hashicorp-cla

Works.

image

blaggacao avatar Mar 15 '22 21:03 blaggacao

Hey @blaggacao

Thanks for making this PR. Could you sign the CLA agreement so we could review it?

Amier3 avatar Mar 22 '22 18:03 Amier3

Hey @blaggacao

Just a reminder that we'll need the CLA signed before reviewing this. Thank you!

Amier3 avatar Jun 07 '22 16:06 Amier3

This feature would be great to have. I'm currently experiencing this issue with short lived tokens and the de-registration and re-registration flow.

ncode avatar Aug 26 '22 11:08 ncode

This feature would be great to have. I'm currently experiencing this issue with short lived tokens and the de-registration and re-registration flow.

Same here, the vercel checks seem to fail, but don't have access to see why.

mgomersbach avatar Aug 26 '22 11:08 mgomersbach

We use Nix to patch our way to happiness, so I'm not immediately incentiviced to push this.

The HC team should feel free to take over.

blaggacao avatar Aug 26 '22 23:08 blaggacao

I approved the Vercel builds and they've both passed.

I'll find someone on the HC team to review the proposed changes.

blake avatar Aug 30 '22 17:08 blake

Hello, I'm experiencing the same issue and I tried the PR and it works. It would be great if it can be reviewed soon.

rehand avatar Mar 12 '24 12:03 rehand

@blake could you try to find someone to review the proposed changes?

rehand avatar Apr 08 '24 13:04 rehand