consul icon indicating copy to clipboard operation
consul copied to clipboard

ui: Give CopyButtons an idle tooltip as well as success/error ones

Open johncowen opened this issue 3 years ago • 2 comments

This PR builds upon https://github.com/hashicorp/consul/pull/10655 and adds a tooltip saying "Copy" to all our CopyButtons.

The success notification is now simply "Copied" as we figured that copying something isn't something to get that excited about! 🎉

Notes:

It would have been nice to try use a conditional modifier here to avoid double buttons. We began by making a single button with a single modifier with conditional arguments, but that didn't work for whatever reason. I quickly tried doubling up the button and using our State component, and that worked fine. So considering this is in one place and we might have the ability to do conditional modifiers soon (there's an RFC somewhere for (modifer 'modifer-name')), I decided to stick with it for this case. We can circle back here when/if the conditional modifier thing happens.

  • [ ] Needs a changelog

johncowen avatar Jul 21 '21 11:07 johncowen

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar Feb 20 '22 01:02 github-actions[bot]

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


John Cowen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Mar 12 '22 17:03 hashicorp-cla