consul-terraform-sync icon indicating copy to clipboard operation
consul-terraform-sync copied to clipboard

Add condition "nodes" that triggers a task everytime a Consul node is updated

Open remilapeyre opened this issue 3 years ago • 3 comments

remilapeyre avatar Aug 17 '21 20:08 remilapeyre

Adding one more comment that is not an ask.

The content added in templates/tftmpl/tmplfunc/nodes.go and its test file would be great to move to the hashicorp/hcat library. It's where general Consul API handling is done for templates. The library will be also adopted by Consul-Template, and I can imagine that others would benefit from your addition for nodes and filtering support!

@mkam has some hcat work inflight too, so that's why it's not an ask for you to move it there. We can handle that and updating the CTS dependency on the library afterwards.

findkim avatar Aug 24 '21 21:08 findkim

Hi @remilapeyre, just for awareness, we did a fairly major refactoring of our conditions code (see https://github.com/hashicorp/consul-terraform-sync/pull/385), so your PR is out of date with how conditions are structured now. Please let us know how you'd like to proceed with your changes!

mkam avatar Oct 04 '21 21:10 mkam

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 12 '22 18:03 hashicorp-cla