consul-template icon indicating copy to clipboard operation
consul-template copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Implement reload signal debouncing

Open komapa opened this issue 2 years ago • 4 comments

Hello, this is an implementation of debouncing reload signals so that only a single reload happens in the span of a single splay period.

I think the changes are pretty self-explanatory and the only thing that needed to change was starting runner.Signal(s) in a go routine so that we can do all operations in parallel and not sequential.

Please let me know if there is a better way to do this. Thank you!

komapa avatar Feb 03 '23 21:02 komapa

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Feb 03 '23 21:02 hashicorp-cla

Just a note that we have been running this in production for the last 2-3 weeks and it has been performing well for us.

komapa avatar Mar 21 '23 00:03 komapa

@komapa is this still running in production, any issues you have noticed?

This is looking good, do you also mind rebasing this before we approve/merge this?

roncodingenthusiast avatar Jun 21 '23 18:06 roncodingenthusiast

Hey @roncodingenthusiast, we ran this for more than a month in production and we did not see any issues. We eventually removed it because we were able to stop the reloads altogether and we did not want to keep having to apply the patch. I think it will be great to get this merged in if you think it looks good.

komapa avatar Jun 21 '23 19:06 komapa