consul-template icon indicating copy to clipboard operation
consul-template copied to clipboard

ability to reload config on windows

Open fredwangwang opened this issue 2 years ago • 3 comments

Consul Template version

v0.25.2 (870905d)

Expected behavior

Would like to have the ability to reload configuration on windows.

Actual behavior

Currently not supported, due to signal (specifically SIGHUP) is not supported on windows

Opened this issue to see if hot reload can still be supported on windows knowing its limitation

fredwangwang avatar Dec 10 '21 18:12 fredwangwang

Hey @fredwangwang, thanks for filing this issue.

There is a related ticket you might find interesting that has some more discussion and seems like a duplicate of this: #1442

eikenb avatar Dec 10 '21 22:12 eikenb

Hi @eikenb, yep I did see that ticket before opening this one :)

If I understand correctly #1442 is about CT sending signal to the process run by CT, whereas this ticket is about sending signal to CT itself after configuration/template change.

If I misunderstood happy to close this and just refer to the other ticket!

fredwangwang avatar Dec 10 '21 23:12 fredwangwang

Thanks for the feedback @fredwangwang.

You are correct that it isn't an exact duplicate, but the code path for CT handing signals is tied very closely to the one running the underlying process as CT is designed to pass through any signal it doesn't handle. In other words I think the solutions to each will be closely related.

eikenb avatar Jan 24 '22 19:01 eikenb