consul-template
consul-template copied to clipboard
hashicorp
Please release source tarballs with Go dependencies vendored in
Is your feature request related to a problem? Please describe. I'm trying to package Consul Template for Fedora and CentOS, and one of the challenges with doing so is that the Go dependencies aren't vendored in the source tree.
Describe the solution you'd like
I'd love for signed source tarballs to be uploaded to GitHub that have all the source preparation steps done already (and perhaps even the Git commit information already burned in) so that the Consul Template code can be built in Fedora with just go build.
Describe alternatives you've considered The only real alternative is:
- Running the steps to prepare the tarball myself and use that. This is possible, but generating my own tarballs for each release is annoying...
Explain any additional use-cases This would be useful for anyone else trying to build Consult Template from source and ship it in distributions or part of greater solutions. It's also useful for people trying to do completely offline builds as distributions do (internet access is not available in distro package build environments).
Additional context N/A
Hey @Conan-Kudo, good to hear from you.
Wouldn't the made dev target work to build it all in one step? Or do you need it to work without network connectivity?
Testing make dev on the source tarball, it all works fine (assuming a go-modules go version is used). The one thing was the git commit ID of the release is missing. I could probably just change the Makefile to use something like release if the git repo is missing.
Thanks for clarifying that @Conan-Kudo. I'll be making a sweep through these issues in a bit after finishing up with a new feature I'm working on. I'll take a look into the possibility then.
Just noticed you said that there was no internet connection during the build in your initial issue report. Missed it when skimming over it. Sorry bout that.