consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

helm:Configurability of readiness probes

Open cerebrate opened this issue 4 years ago • 3 comments

It would be very useful if it was possible to configure the parameters of the readiness and liveness probes implemented by the chart. At times of high load, I frequently find Consul servers and even occasionally agents being terminated due to failures of readiness probes for their pods, and so far as I can tell, there is no actual underlying problem that would justify this termination - merely a slow response due to load.

cerebrate avatar Dec 07 '20 05:12 cerebrate

Additionally, when using a GKE Ingress, it has to model the health checks from the readiness probe, and since it is using an "exec" instead of httpGet, they can't model the healthchecks automatically. Is there a specific reason that they health checks are not using httpGet? Maybe back in the olden days it didn't support https? 🤷

In my opinion, the liveness (readiness/startup) probes should all be in values.yaml so they can be easily customized instead of being "hard coded" in the template files.

REF:

  • https://cloud.google.com/kubernetes-engine/docs/concepts/ingress#health_checks
  • https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/

TJM avatar Jun 11 '21 14:06 TJM

@cerebrate or @TJM Are the issues still occurring with the latest Consul 1.12 or 1.13.x releases? If so, do you have a PR that we could review that could perhaps address the sort of issues you are seeing during Consul Server startup?

david-yu avatar Aug 19 '22 22:08 david-yu

I am no longer experiencing the issue, but unfortunately I can't tell you if it would otherwise have gone away with the latest releases since, for me, it went away with a hardware upgrade. Sorry I don't have more useful information.

cerebrate avatar Aug 21 '22 12:08 cerebrate

Closing as no feedback was given based on current releases of Consul K8s and Consul. Please open a new issue if more attention is needed.

david-yu avatar Nov 17 '22 01:11 david-yu