consul-k8s
consul-k8s copied to clipboard
Backport of Datadog Unix Socket Path Custom Path fix into release/1.3.x
Backport
This PR is auto-generated from #3635 to be assessed for backporting due to the inclusion of the label backport/1.3.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR
Initial integration hard-coded Unix Domain Socket hostPath
for the consul-server statefulset, making the Helm override global.metrics.datadog.dogstatsd.dogstatsdAddr
not useful if users wanted/needed a custom UDS socket path beyond the default value of /var/run/datadog
.
# server-statefulset.yaml
...
volumes:
- name: dsdsocket
hostPath:
path: /var/run/datadog
type: DirectoryOrCreate
This PR updates this to use the helm override as intended for custom UDS paths
# server-statefulset.yaml
...
volumes:
- name: dsdsocket
hostPath:
path: {{ dir .Values.global.metrics.datadog.dogstatsd.dogstatsdAddr | trimAll "\"" }}
type: DirectoryOrCreate
How I've tested this PR
Updated server-statefulset.bats
with the following tests for default and non-default paths:
-
"server/StatefulSet: datadog unix socket path name rendering for hostPath volume and volumeMount using default"
-
"server/StatefulSet: datadog unix socket path name rendering for hostPath volume and volumeMount using non default"
Tested locally running a k3d cluster with latest build. Repo
How I expect reviewers to test this PR
👀 Acceptance test results
Checklist
- [X] Tests added
- [X] CHANGELOG entry added
Overview of commits
- 7512f0ed08a20ef93e8c668cfe05d5068ba6599c - a64ccf29384b443f93c05ea85ae0b8c60c139131 - bf638d2685134e79156c60fda3404ce4b16cdb4e