consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

gRPC port is exposed even if gRPC is disabled

Open d-mosinski-s opened this issue 1 year ago • 2 comments

Changes proposed in this PR

Disable gRPC node port 8502 when client gRPC is disabled

How I've tested this PR

Added changelog and tests. It was also tested by running modified chart from local code.

How I expect reviewers to test this PR

gRPC node port 8502 should be disabled in consul client when client.grpc is disabled. Currently it is conflicting with server grpc node port when running server and client same node. Similar if should be applied to server template (do not expose 8502 when connect: is disabled) but maybe in different PR.

Checklist

d-mosinski-s avatar Jan 22 '24 13:01 d-mosinski-s

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Jan 22 '24 13:01 hashicorp-cla

Added changelog and tests. It was also tested by running modified chart from local code.

d-mosinski-s avatar Jan 23 '24 09:01 d-mosinski-s