consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

Allow setting only the registry for docker images in the helm chart instead of full URI

Open komapa opened this issue 1 year ago • 2 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

Yes. Let me explain :)

We are mirroring all of consul-k8s dependent images in our private registry in the following format:

      global:
        image: ${local.registry}/hub/hashicorp/consul-enterprise:${local.consul_version}
        imageK8S: ${local.registry}/hub/hashicorp/consul-k8s-control-plane:${local.consul_chart_version}
        imageConsulDataplane: ${local.registry}/hub/hashicorp/consul-dataplane:${local.consul_chart_version}

The immediate problem is that releases for 1.1.x do not track the same versioning in consul-dataplane project! consul-k8s is at 1.1.8 but consul-dataplane is at 1.1.7 and the above logic fails while it works perfectly for 1.2.x and 1.3.x series.

Feature Description

It will be great if we can just specify:

global:
   registry: ${local.registry}/hub/hashicorp

and then you fill in with consul-k8s-control-plane:1.1.8 and consul-dataplane:1.1.7 the rest.

Use Case(s)

Using private registries

komapa avatar Dec 22 '23 15:12 komapa

Yes, this is pretty much required. No idea why it hasn't been done yet. It makes using renovate bot so much harder...

dmpe avatar May 21 '24 16:05 dmpe

@david-yu if this is a "breaking change" like you mentioned in https://github.com/hashicorp/consul-k8s/issues/644, can we at least bring consul-dataplane versioning in line with the versioning of consul-k8s? We got bit again just now because the official 1.1.11 was released and overwrite out mirrored image and started erroring for envoy.tracing (unrelated issue but proving the point).

Just make the versions at least match for 1.1.x just like they do for the other minor versions and will make the problem a little worse.

Thanks!

komapa avatar May 21 '24 16:05 komapa