consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

Support telemetry.disable_hostname

Open DanielYWoo opened this issue 2 years ago • 2 comments

Changes proposed in this PR:

  • Support telemetry.disable_hostname

How I've tested this PR: with the unit test in server-config-configmap.bats however, for some reason there are other failed test cases, I am not sure if they are related to this PR.

How I expect reviewers to test this PR: help me fix the unrelated unit test

Checklist:

DanielYWoo avatar Aug 31 '23 16:08 DanielYWoo

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


0 out of 2 committers have signed the CLA.

  • [ ] Daniel Wu
  • [ ] DanielYWoo

Daniel Wu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Aug 31 '23 16:08 hashicorp-cla

@DanielYWoo Could you tell us the use case for this PR (service mesh or service discovery)? Also what was the problem the PR was looking to address? Thanks that helps for context when reviewing the PR.

david-yu avatar Jan 22 '24 17:01 david-yu