consul-k8s
consul-k8s copied to clipboard
docs: Update outdated `consul.io` links (#2708)
Changes proposed in this PR:
- Pull in docs changes from #2708
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist:
- [ ] Tests added
- [ ] CHANGELOG entry added
@tanmay-pnaik Looks like our helm tests are failing here, so I can't pull these in. Are you able to make a PR against this branch to fix those test failures?
--- FAIL: TestFullValues (0.05s)
FAIL TestFullValues (0.05s)
FAIL .
DONE 25 tests, 1 failure in 8.334s
=== RUN TestFullValues
main_test.go:508:
Error Trace: main_test.go:508
Error: output not equal, actual output to full-values.actual
Test: TestFullValues
--- FAIL: TestFullValues (0.04s)
FAIL TestFullValues (re-run 1) (0.04s)
FAIL .
DONE 2 runs, 26 tests, 2 failures in 8.748s
=== RUN TestFullValues
main_test.go:508:
Error Trace: main_test.go:508
Error: output not equal, actual output to full-values.actual
Test: TestFullValues
--- FAIL: TestFullValues (0.04s)
FAIL TestFullValues (re-run 2) (0.04s)
FAIL .
=== Failed
=== FAIL: . TestFullValues (0.05s)
main_test.go:508:
Error Trace: main_test.go:508
Error: output not equal, actual output to full-values.actual
Test: TestFullValues
=== FAIL: . TestFullValues (re-run 1) (0.04s)
main_test.go:508:
Error Trace: main_test.go:508
Error: output not equal, actual output to full-values.actual
Test: TestFullValues
=== FAIL: . TestFullValues (re-run 2) (0.04s)
main_test.go:508:
Error Trace: main_test.go:508
Error: output not equal, actual output to full-values.actual
Test: TestFullValues
DONE 3 runs, 27 tests, 3 failures in 9.144s
Hi @david-yu I have created https://github.com/hashicorp/consul-k8s/pull/2802
However, I am not sure why the tests are failing. I have checked that the same links are changed in both full-values.golden and full-values.yaml and also checked for errors in punctuation, spellings, etc. but haven't found anything significant.