consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Run API Gateway with no local agents

Open andrewstucki opened this issue 3 years ago • 1 comments

Changes proposed in this PR:

  • This adds the ability to run and api gateway when local clients are disabled. It coincides with TTL-based health checks being the norm for our deployment entrypoint here.

How I've tested this PR:

  • Unit tests and manually.

Checklist:

  • [x] Tests added
  • [ ] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry. Entries should use present tense (e.g. Add support for...)

andrewstucki avatar Sep 15 '22 21:09 andrewstucki

Is the externalServers conditional wrapping because consul-k8s doesn't support disabling clients with cluster-hosted servers yet, or some other reason?

mikemorris avatar Sep 16 '22 15:09 mikemorris

@andrewstucki Is this ready for review? Feel free to add the consul-k8s team and it should auto assign reviewers.

david-yu avatar Sep 23 '22 05:09 david-yu

Yep @david-yu it should be ready to go

andrewstucki avatar Sep 27 '22 14:09 andrewstucki

@andrewstucki Was briefly chatting with @ishustava and she mentioned there is a ton of agentless changes that may impact this PR. Also she asked is this only supposed to use external servers and noticed that it looks like its still using HOST_IP in some configurations.

david-yu avatar Sep 27 '22 21:09 david-yu

@david-yu : Ah, see that I missed that the agentless stuff was all going into agentless-base branch, I'll rebase the work off of there and clean it up.

andrewstucki avatar Sep 27 '22 21:09 andrewstucki