consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

Fix issue where API gateways were being mis-labeled as Sidecar proxies

Open t-eckert opened this issue 2 years ago • 1 comments

Changes proposed in this PR:

  • Fix an issue where pods running API Gateway were being mis-labeled as "Sidecar" pods

How I've tested this PR:

  • Edited the unit test to test the correct behavior.
  • Manual testing against a cluster

How I expect reviewers to test this PR:

  • Running the unit tests

Checklist:

  • [x] Tests added
  • [ ] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry. Entries should use present tense (e.g. Add support for...)

t-eckert avatar Aug 09 '22 20:08 t-eckert

I don't feel that this needs a CHANGELOG entry unless Envoy debugging goes out before this gets merged. The bug never reached production otherwise.

t-eckert avatar Aug 09 '22 20:08 t-eckert

Can we investigate why the acceptance tests are failing before we merge this?

thisisnotashwin avatar Aug 10 '22 20:08 thisisnotashwin

Can we investigate why the acceptance tests are failing before we merge this?

Oh yeah, that's been most of my day so far. It's weird.

t-eckert avatar Aug 10 '22 20:08 t-eckert