consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Add extraLabels to connectInject and serverACLInit pods

Open s-andresen opened this issue 2 years ago • 2 comments

Changes proposed in this PR: Added extraLabels to connectInject and serverACLInit in values.yaml so if declared in the values file then these additional labels will be added to the pods

How I've tested this PR: Tested the helm chart on my kubernetes cluster with and without declaring the extraLabels to ensure everything works as expected.

How I expect reviewers to test this PR: Same as how I tested

Checklist:

  • [ ] Tests added
  • [ ] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry. Entries should use present tense (e.g. Add support for...)

s-andresen avatar Jul 28 '22 11:07 s-andresen

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Jul 28 '22 11:07 hashicorp-cla

@s-andresen Could you tell us whether you expect to apply the same labels for both components? We had a similar PR previously but opted for an approach to create a label for all components for a global label instead.

david-yu avatar Aug 15 '22 20:08 david-yu

Closing in favor of https://github.com/hashicorp/consul-k8s/pull/1678, could you open a separate PR That enables ServerACLInit with bats test included?

david-yu avatar Nov 12 '22 18:11 david-yu