consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

Expose imagePullPolicy

Open washtubs opened this issue 3 years ago • 2 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

We are deploying this as a subchart, and trying to prevent forking. It is possible but very difficult to modify imagePullPolicy with kustomize, and it would be nice if this was simply exposed in the values.yaml like it is for vault.

Feature Description

Expose an imagePullPolicy attribute. A global attribute would be acceptable. Doesn't have to be one for the normal image and another for imageK8s, but I'll just point out that that's what vault does.

Use Case(s)

Changing the imagePullPolicy to Always in cases where we override the image to something with a fixed tag where the underlying image is updated in the registry. Not a great practice but still valid, and I'm sure there are plenty of other valid use cases.

Contributions

I would be happy to contribute.

washtubs avatar Apr 29 '22 17:04 washtubs

Hi @washtubs that is a good feature request and I have also noticed that there is a imagePullPolicy with the vault Helm chart. Would you be willing to open up a PR that proposes how we could address this issue?

david-yu avatar Jun 02 '22 22:06 david-yu

Re-opening as the changes had to be reverted prior to our GA release.

david-yu avatar Jul 05 '23 21:07 david-yu