consul-esm icon indicating copy to clipboard operation
consul-esm copied to clipboard

[WIP] Feature/add grpc checks

Open VictorBac opened this issue 4 years ago • 5 comments

Hi guys, I am trying to add support for GRPC checks following https://github.com/hashicorp/consul-esm/issues/117

For some reason, when this line runs: https://github.com/VictorBac/consul-esm/blob/feature/add-grpc-checks/check.go#L488 my check is updated, but some information are deleted (causing following checks to be invalid)

Going from:

$ curl http://consul:8500/v1/health/node/external-node?pretty
...
            "Definition": {
                "grpc": "my-grpc-service.com:443",
                "TLSSkipVerify": true,
                "GRPCUseTLS": true,
                "interval": "10s"
            }

to:

            "Definition": {
                "TLSSkipVerify": true,
                "interval": "10s"
            }

and the GRPCUseTLS does not seem to be respected.

PS: to build this, I had too add GRPC to the check definition: https://github.com/hashicorp/consul/pull/12108/files

Do you know what I am missing here ?

VictorBac avatar Jan 21 '22 21:01 VictorBac

Hey @VictorBac,

I don't have time to look at this very closely but have marked it for others as much as I could. If this requires consul changes you might want to ask there about if those are absolutely needed and, if so, they'd be interested in getting it added. Once you have that done then maybe come back here and update this.

eikenb avatar Jan 31 '22 23:01 eikenb

Thank you @eikenb !

I am waiting for Consul to release some changes I made in their repo. Then this will work.

I'll come back when it's done.

VictorBac avatar Feb 01 '22 12:02 VictorBac

Marked this as waiting-reply to note that we're waiting on a ping about consul having been updated so this is ready for review.

eikenb avatar Feb 14 '22 21:02 eikenb

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 12 '22 17:03 hashicorp-cla