consul-dataplane icon indicating copy to clipboard operation
consul-dataplane copied to clipboard

Binary build fixes for Windows

Open pglass opened this issue 2 years ago • 2 comments

  • Switch bootstrap config file from a named Unix pipe to a tempfile, since there shouldn't be anything sensitive in the bootstrap config file
  • Remove x-consul-token from the bootstrap config template since the token is injected into the gRPC stream by an interceptor

pglass avatar Nov 04 '22 21:11 pglass

Just to let you know, I am using this code (updated with main branch of course) and using it on Windows nodes in AWS, and for now it seems to work fine!

joselo85 avatar Dec 05 '22 21:12 joselo85

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Paul Glass seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Oct 23 '23 16:10 hashicorp-cla