boundary-ui icon indicating copy to clipboard operation
boundary-ui copied to clipboard

refactor: 💡 remove ember-power-select duplicate dependency

Open lisbet-alvarez opened this issue 1 month ago • 2 comments

Description

Remove duplicate dependency.

How to Test

Validate select dropdown still works here or locally.

Checklist

  • [ ] I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • [ ] I have added steps to reproduce and test for bug fixes in the description
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • [x] I have documented a clear reason for, and description of, the change I am making.
  • [ ] If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • [ ] If applicable, I've documented the impact of any changes to security controls. Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

lisbet-alvarez avatar Nov 17 '25 22:11 lisbet-alvarez

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
boundary-ui Ready Ready Preview, Comment Dec 17, 2025 0:18am
boundary-ui-desktop Ready Ready Preview, Comment Dec 17, 2025 0:18am

vercel[bot] avatar Nov 17 '25 22:11 vercel[bot]

I know the docs offer the import 'ember-power-select/styles'; option but I'm not seeing the power select styles in the vendor.css or admin.css. I do see the power select classes from hds. I'm not sure if there are caveats to this method? I'm not sure if I'm missing something or maybe these styles aren't needed?

Looks like the styles are being injected directly into <style> when using the import option. Screenshot 2025-11-18 at 11 11 52 AM versus @use option Screenshot 2025-11-18 at 11 14 03 AM

~~It doesn't seem like having the styles be injected directly into the DOM is ideal. Therefore, i think in the end we are still going to need the ember-power-select devDep. Unless I am misunderstanding~~

EDIT Hds team approves of this approach & in future release they'll look into importing styles so consumers dont have to. hds team also updated docs 🙌.

lisbet-alvarez avatar Nov 18 '25 19:11 lisbet-alvarez