hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

ci: detect existing minio operator installations correctly - cherry pick to v0.67

Open nathanklick opened this issue 2 months ago • 4 comments

Description

This pull request updates configuration and setup scripts related to Kubernetes and Solo cluster deployments. The main focus is on improving the detection of the MinIO operator, adjusting cluster setup commands, and standardizing environment variables.

Kubernetes and Solo cluster setup improvements:

  • Updated the MinIO operator detection logic in .github/workflows/support/citr/Taskfile.citr.yml to check for pods (instead of services) with the appropriate labels, making the check more reliable.
  • Modified the Solo cluster setup command to always include the --no-prometheus-stack flag, preventing Prometheus stack installation in those cases.

Environment variable standardization:

  • Changed the default value of SOLO_CLUSTER_RELEASE_NAME from cluster_name to solo-cluster-setup in .github/workflows/support/citr/Taskfile.yml for consistency across deployments.

Related Issues

Fixes #21907

nathanklick avatar Oct 28 '25 23:10 nathanklick

:white_check_mark: Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
:white_check_mark: Open Source Security 0 0 0 0 0 issues

:computer: Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

lfdt-bot avatar Oct 28 '25 23:10 lfdt-bot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.67   #21909   +/-   ##
===============================================
  Coverage           71.31%   71.31%           
  Complexity          24361    24361           
===============================================
  Files                2664     2664           
  Lines              103756   103756           
  Branches            10842    10842           
===============================================
  Hits                73993    73993           
  Misses              25714    25714           
  Partials             4049     4049           

Impacted file tree graph

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 28 '25 23:10 codecov[bot]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark:
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ff2fa2e1400f0da65a2d0c5ea7cda691ab58040d) 103661 77998 75.24%
Head commit (d74d284b7ea68c0f17c806df09139160894a1737) 103661 (+0) 77998 (+0) 75.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21909) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

codacy-production[bot] avatar Oct 28 '25 23:10 codacy-production[bot]

There are additional changes that need to also be cherry picked to the release/0.67 branch if we plan to merge this PR.

See the failed SDPT here and SDLT here.

andrewb1269 avatar Nov 06 '25 18:11 andrewb1269