hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

fix: delayed start logic for deterministic image

Open matteriben opened this issue 10 months ago • 1 comments

The previous check could fail if the clock was stepped.

Description:

Fixes problem with delayed start logic for deterministic image. Previous logic relied on start time of pid 1. However, if the system clock was stepped apparent start time of pid 1 can change subsequently preventing the service from starting correctly.

This change replaces file/time based check for initial start with a logical check based on s6 wantedup semantics. Initially wantedup will be true for this service until the service is configured not to restart on line 10.

Related issue(s):

Fixes #18264

matteriben avatar Mar 10 '25 23:03 matteriben

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18265   +/-   ##
=======================================
  Coverage        ?   69.36%           
  Complexity      ?    23153           
=======================================
  Files           ?     2631           
  Lines           ?   100254           
  Branches        ?    10356           
=======================================
  Hits            ?    69543           
  Misses          ?    26751           
  Partials        ?     3960           

Impacted file tree graph

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 10 '25 23:03 codecov[bot]

Mirrored PR here: #19070

rbarker-dev avatar May 06 '25 18:05 rbarker-dev

Moved to PR#19126.

matteriben avatar May 12 '25 22:05 matteriben